Skip to content

Commit

Permalink
Remove old comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Tigrov committed Nov 4, 2023
1 parent 5ee6fb6 commit 2fbfc10
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
1 change: 0 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

## 1.1.2 under development

- Bug #746: Refactor `DMLQueryBuilder` and fix: unique indexes in `upsert()`, column names with table name and brackets, `batchInsert()` with associative arrays, enhanced documentation of `batchInsert()` and `update()` (@Tigrov)
- Enh #746: Refactor `AbstractDMLQueryBuilder` (@Tigrov)
- Bug #746: Fix `AbstractDMLQueryBuilder::upsert()` when unique index is not at the first position of inserted values (@Tigrov)
- Bug #746: Typecast values in `AbstractDMLQueryBuilder::batchInsert()` if column names with table name and brackets (@Tigrov)
Expand Down
5 changes: 1 addition & 4 deletions src/QueryBuilder/AbstractDMLQueryBuilder.php
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,7 @@ public function batchInsert(string $table, array $columns, iterable $rows, array
foreach ($rows as $row) {
$i = 0;
$placeholders = $columnKeys;
/**
* @psalm-var string|int $key
* @psalm-var mixed $value
*/

foreach ($row as $key => $value) {
/** @psalm-var string|int $columnName */
$columnName = $columns[$key] ?? (isset($columnKeys[$key]) ? $key : $columnNames[$i] ?? $i);

Check failure on line 71 in src/QueryBuilder/AbstractDMLQueryBuilder.php

View workflow job for this annotation

GitHub Actions / psalm / PHP 8.1-ubuntu-latest

MixedArrayTypeCoercion

src/QueryBuilder/AbstractDMLQueryBuilder.php:71:56: MixedArrayTypeCoercion: Coercion from array offset type 'array-key' to the expected type 'string' (see https://psalm.dev/195)

Check failure on line 71 in src/QueryBuilder/AbstractDMLQueryBuilder.php

View workflow job for this annotation

GitHub Actions / psalm / PHP 8.2-ubuntu-latest

MixedArrayTypeCoercion

src/QueryBuilder/AbstractDMLQueryBuilder.php:71:56: MixedArrayTypeCoercion: Coercion from array offset type 'array-key' to the expected type 'string' (see https://psalm.dev/195)
Expand Down

0 comments on commit 2fbfc10

Please sign in to comment.