Improve test coverage

yiisoft · Oct 9, 2024 · 4796bdf · 4796bdf
1 parent 704df9c
commit 4796bdf
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 2 deletions.
diff --git a/src/QueryBuilder/AbstractColumnDefinitionBuilder.php b/src/QueryBuilder/AbstractColumnDefinitionBuilder.php
@@ -267,16 +267,26 @@ protected function buildReferenceDefinition(ColumnSchemaInterface $column): stri
         }
 
         if (null !== $onDelete = $reference?->getOnDelete()) {
-            $sql .= ' ON DELETE ' . $onDelete;
+            $sql .= $this->buildOnDeleteClause($onDelete);
         }
 
         if (null !== $onUpdate = $reference?->getOnUpdate()) {
-            $sql .= ' ON UPDATE ' . $onUpdate;
+            $sql .= $this->buildOnUpdateClause($onUpdate);
         }
 
         return $sql;
     }
 
+    protected function buildOnDeleteClause(string $onDelete): string
+    {
+        return " ON DELETE $onDelete";
+    }
+
+    protected function buildOnUpdateClause(string $onUpdate): string
+    {
+        return " ON UPDATE $onUpdate";
+    }
+
     /**
      * Builds the type definition for the column. For example: `varchar(128)` or `decimal(10,2)`.
      *

diff --git a/tests/Provider/QueryBuilderProvider.php b/tests/Provider/QueryBuilderProvider.php
@@ -1574,6 +1574,9 @@ public static function buildColumnDefinition(): array
         $reference->onDelete('CASCADE');
         $reference->onUpdate('CASCADE');
 
+        $referenceWithSchema = clone $reference;
+        $referenceWithSchema->foreignSchemaName('ref_schema');
+
         return [
             PseudoType::PK => ['integer PRIMARY KEY AUTO_INCREMENT', PseudoType::PK],
             PseudoType::UPK => ['integer UNSIGNED PRIMARY KEY AUTO_INCREMENT', PseudoType::UPK],
@@ -1679,6 +1682,15 @@ public static function buildColumnDefinition(): array
                 ),
                 ColumnBuilder::integer()->reference($reference),
             ],
+            'reference($referenceWithSchema)' => [
+                DbHelper::replaceQuotes(
+                    <<<SQL
+                    integer REFERENCES [[ref_schema]].[[ref_table]] ([[id]]) ON DELETE CASCADE ON UPDATE CASCADE
+                    SQL,
+                    static::$driverName,
+                ),
+                ColumnBuilder::integer()->reference($referenceWithSchema),
+            ],
         ];
     }
 }