-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring of AbstractSchema::getColumnPhpType()
method
#728
Conversation
Tigrov
commented
Jul 22, 2023
Q | A |
---|---|
Is bugfix? | ❌ |
New feature? | ❌ |
Breaks BC? | ❌ |
Fixed issues | - |
PR Summary
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #728 +/- ##
============================================
- Coverage 99.83% 99.73% -0.10%
+ Complexity 1272 1269 -3
============================================
Files 63 63
Lines 3040 3038 -2
============================================
- Hits 3035 3030 -5
- Misses 5 8 +3
☔ View full report in Codecov by Sentry. |
// abstract type => php type | ||
SchemaInterface::TYPE_TINYINT => SchemaInterface::PHP_TYPE_INTEGER, | ||
SchemaInterface::TYPE_SMALLINT => SchemaInterface::PHP_TYPE_INTEGER, | ||
SchemaInterface::TYPE_INTEGER => SchemaInterface::PHP_TYPE_INTEGER, | ||
SchemaInterface::TYPE_BIGINT => SchemaInterface::PHP_TYPE_INTEGER, | ||
SchemaInterface::TYPE_INTEGER => PHP_INT_SIZE === 4 && $column->isUnsigned() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This behavior is for all dbms or is specific, i find it strange.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In PHP for 32bit system maximum integer number is 2147483647
. Seems, in most (maybe in all) DBMS unsigned int value will be more (for example in MySQL — 4294967295
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, add line to changelog
👍 |