Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some comments are left for review and will be removed after.
ColumnSchema::dateTimeFormat()
andColumnSchema::$dateTimeFormat
can be removed, in this case it will be necessary to determine the format fromColumnSchema
each time when casting values.Update 09.08.2023
ColumnSchema::hasTimezone()
can be replaced with two new abstract typesSchemaInterface::TYPE_TIMESTAMPTZ
andSchemaInterface::TYPE_TIMETZ
Both options (remove methods) can be done without loss of performance if type casting will be optimized as here #737