-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace object to stringable #747
Replace object to stringable #747
Conversation
PR Summary
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #747 +/- ##
============================================
- Coverage 99.73% 93.58% -6.16%
Complexity 1269 1269
============================================
Files 63 63
Lines 3038 3038
============================================
- Hits 3030 2843 -187
- Misses 8 195 +187
☔ View full report in Codecov by Sentry. |
I see there are some failed tests.
In Yiisoft\Db\Tests\Common\CommonSchemaTest: AnyCaseValue object used as name, which can include array or string value. I didn't understand that test case. What should I do with this test case? P.S. I want to start contribute with this small pull-request. I will be happy for any suggestion. Don't judge strictly :) |
First option would be backwards compatible. You can mark |
Also see #738 (comment). That's a good question. |
Resolves #738