Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BC issues #775

Merged
merged 4 commits into from
Nov 12, 2023
Merged

Fix BC issues #775

merged 4 commits into from
Nov 12, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Nov 12, 2023

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

what-the-diff bot commented Nov 12, 2023

PR Summary

  • Improved Workflow File for GitHub Actions
    Changes have been made to our GitHub workflow file. These modifications are particularly about specifying certain paths for push and pull request activities, allowing us to better track and manage the changes.

  • Updated Method Parameter in the Query Module
    The withQuery method, utilized in our Query system, has a modification in its input. This method now strictly demands a string alias parameter instead of a more broad ExpressionInterface|string type. This change will lead to more accurate data processing.

  • Reflecting Parameter Changes in Query Interface
    The withQuery method in the QueryPartsInterface has been adjusted identical to the above change for consistency throughout the system.

  • Testing Adjustments
    We've also made some changes inside our test provider. Specifically, the 'expression' test case has been removed from the cteAliases method. This is to align our testing structure with the updates made on the core methods.

Copy link

codecov bot commented Nov 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (63f68c0) 99.05% compared to head (5b1d5c9) 99.02%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #775      +/-   ##
============================================
- Coverage     99.05%   99.02%   -0.04%     
  Complexity     1271     1271              
============================================
  Files            67       67              
  Lines          3080     3080              
============================================
- Hits           3051     3050       -1     
- Misses           29       30       +1     
Files Coverage Δ
src/Query/Query.php 100.00% <100.00%> (ø)
src/Query/QueryPartsInterface.php 0.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/Query/QueryPartsInterface.php Show resolved Hide resolved
src/QueryBuilder/AbstractDMLQueryBuilder.php Outdated Show resolved Hide resolved
@vjik vjik merged commit 133d972 into master Nov 12, 2023
162 of 171 checks passed
@vjik vjik deleted the fix-bc-issues branch November 12, 2023 10:29
@Tigrov Tigrov mentioned this pull request Nov 13, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants