Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify result type of ConstraintSchemaInterface::getTableIndexes() method to IndexConstraint[] #784

Merged
merged 2 commits into from
Nov 26, 2023

Conversation

vjik
Copy link
Member

@vjik vjik commented Nov 24, 2023

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

what-the-diff bot commented Nov 24, 2023

PR Summary

  • Enhancement to the ConstraintSchemaInterface::getTableIndexes() method
    This PR adds an enhancement that updates the result type of the getTableIndexes() method in ConstraintSchemaInterface from a more general “array” type to the specific IndexConstraint[]. This modification enhances the precision of the data type, ensuring that the function only returns IndexConstraint elements.

  • Removal of unused code in AbstractSchema::getTableIndexes()
    We have removed certain pieces of code from the getTableIndexes() method in AbstractSchema, enhancing code cleanliness and making the function more efficient by eliminating code that was not being used.

  • Removal of an unnecessary import in AbstractDMLQueryBuilder
    This PR also includes a cleanup change that removes an unnecessary import of Yiisoft\Db\Constraint\IndexConstraint in the AbstractDMLQueryBuilder. This helps to reduce clutter and maintain neatness in our codebase.

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8a3d81f) 99.64% compared to head (b3be66b) 99.64%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #784      +/-   ##
============================================
- Coverage     99.64%   99.64%   -0.01%     
+ Complexity     1272     1271       -1     
============================================
  Files            63       63              
  Lines          3061     3060       -1     
============================================
- Hits           3050     3049       -1     
  Misses           11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik marked this pull request as ready for review November 24, 2023 13:23
@vjik vjik requested a review from a team November 24, 2023 13:24
@vjik vjik added the status:code review The pull request needs review. label Nov 24, 2023
@vjik vjik merged commit f655cb7 into master Nov 26, 2023
170 of 171 checks passed
@vjik vjik deleted the improve-index-type branch November 26, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants