Restore Query::one interface

[darkdef]

Q	A
Is bugfix?	✔️
New feature?	✔️
Breaks BC?	✔️/❌

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.61%. Comparing base (6a8ceea) to head (b6db838).

Additional details and impacted files

@@            Coverage Diff            @@
##             master     #798   +/-   ##
=========================================
  Coverage     99.61%   99.61%           
  Complexity     1372     1372           
=========================================
  Files            74       74           
  Lines          3362     3362           
=========================================
  Hits           3349     3349           
  Misses           13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Tigrov]

BatchQueryResult::$value and related methods also should have the type array|object|null

db/src/Query/BatchQueryResult.php

Line 43 in ef81e8b

private mixed $value;

[what-the-diff]

PR Summary

• Modifications to the queryOne() method
  The queryOne() function, which can be found in AbstractCommand.php, CommandInterface.php, and CommandInterfaceProxy.php, underwent revisions that enable it to provide a more diverse set of results. This function formerly returned only arrays, but with this update, it can now return an array, an object, or even a null value. This improvement enhances the flexibility and coverage of the response types our system can deliver.

• Improvements to the one() method
  Similar to the queryOne() modifications, we have updated the one() function in Query.php and QueryInterface.php to return either an array, an object, or a null value. Previously, the function was limited to just array results. This change broadens the scope of possible outputs, making our system more diverse and adaptable in responding to different query requirements.

[darkdef]

BatchQueryResult::$value and related methods also should have the type array|object|null

It's maybe incorrect for query with one column as scalar type.

[Tigrov]

BatchQueryResult::$value and related methods also should have the type array|object|null

It's maybe incorrect for query with one column as scalar type.

This should be an array or object ($row) or array of arrays or objects ($rows) or null, but seems this is not related with the PR.

db/src/Query/BatchQueryResult.php

Line 103 in ef81e8b

$this->dataReader = $this->query->createCommand()->query();

db/src/Command/AbstractCommand.php

Lines 425 to 429 in ef81e8b

	public function query(): DataReaderInterface
	{
	/** @psalm-var DataReaderInterface */
	return $this->queryInternal(self::QUERY_MODE_CURSOR);
	}

And after custom populate closure $rows can be changed to array of objects

db/src/Query/BatchQueryResult.php

Lines 108 to 110 in ef81e8b

	if ($this->populateMethod !== null) {
	return (array) ($this->populateMethod)($rows, $this->query->getIndexBy());
	}

[Tigrov]

Needs line to changelog

[vjik]

Do we need also fix type of CommandInterface::queryAll()?

[vjik]

Needs line to changelog

And fill UPGRADE.md too

[Tigrov]

Do we need also fix type of CommandInterface::queryAll()?

Currently it looks excessive and needs refactoring DbArrayHelper for supporting objects but it looks redundant.