Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor insertBatch(), add getRawTableName() to QuoterInterface #834

Merged
merged 3 commits into from
May 6, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented May 5, 2024

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.44%. Comparing base (ce1ddb5) to head (466b4d0).

❗ Current head 466b4d0 differs from pull request most recent head 0b52360. Consider uploading reports for the commit 0b52360 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #834      +/-   ##
============================================
- Coverage     99.44%   99.44%   -0.01%     
+ Complexity     1324     1323       -1     
============================================
  Files            64       64              
  Lines          3252     3249       -3     
============================================
- Hits           3234     3231       -3     
  Misses           18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov added the status:code review The pull request needs review. label May 5, 2024
Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need notes in UPGRADE.md. Otherwise, it's good.

@Tigrov Tigrov requested a review from vjik May 6, 2024 04:11
@Tigrov Tigrov merged commit d594a8b into master May 6, 2024
2 checks passed
@Tigrov Tigrov deleted the refactor-insertBatch branch May 6, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants