Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AbstractDMLQueryBuilder::getTypecastValue() method #836

Merged
merged 3 commits into from
May 7, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented May 6, 2024

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues #767

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.56%. Comparing base (d594a8b) to head (25ae374).

❗ Current head 25ae374 differs from pull request most recent head cd47eaf. Consider uploading reports for the commit cd47eaf to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #836      +/-   ##
============================================
+ Coverage     98.92%   99.56%   +0.64%     
+ Complexity     1323     1321       -2     
============================================
  Files            64       64              
  Lines          3249     3245       -4     
============================================
+ Hits           3214     3231      +17     
+ Misses           35       14      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov added the status:code review The pull request needs review. label May 6, 2024
@Tigrov Tigrov merged commit 7bb36b2 into master May 7, 2024
2 checks passed
@Tigrov Tigrov deleted the remove-getTypecastValue branch May 7, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants