Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove $table parameter from normalizeColumnNames() #837

Merged
merged 2 commits into from
May 8, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented May 7, 2024

Remove $table parameter from normalizeColumnNames() and getNormalizeColumnNames() methods of AbstractDMLQueryBuilder class

Q A
Is bugfix?
New feature?
Breaks BC? ✔️
Fixed issues #767

…lizeColumnNames()` methods of `AbstractDMLQueryBuilder` class
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.56%. Comparing base (7bb36b2) to head (37012e3).

❗ Current head 37012e3 differs from pull request most recent head 87f473d. Consider uploading reports for the commit 87f473d to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #837   +/-   ##
=========================================
  Coverage     99.56%   99.56%           
  Complexity     1321     1321           
=========================================
  Files            64       64           
  Lines          3245     3245           
=========================================
  Hits           3231     3231           
  Misses           14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov added the status:code review The pull request needs review. label May 7, 2024
@Tigrov Tigrov requested a review from a team May 7, 2024 12:04
@Tigrov Tigrov merged commit c702494 into master May 8, 2024
2 checks passed
@Tigrov Tigrov deleted the remove-normalizeColumnNames branch May 8, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants