Pdo driver interface/password sensitive param

[heap-s]

Q	A
Is bugfix?	❌
New feature?	❌
Breaks BC?	❌
Fixed issues	#872

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.72%. Comparing base (99d69c1) to head (42ac659).

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #874      +/-   ##
============================================
- Coverage     99.61%   98.72%   -0.90%     
  Complexity     1372     1372              
============================================
  Files            74       74              
  Lines          3360     3360              
============================================
- Hits           3347     3317      -30     
- Misses           13       43      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Tigrov]

Can we test it?

[samdark]

@Tigrov not really.

[vjik]

Hm, if we can throw exception, then we can check trace. Example: https://3v4l.org/OYZAt

[Tigrov]

To get an exception we can pass an integer value or null instead of string

[heap-s]

Have we decided what we're doing here in terms of testing?

[Tigrov]

Have we decided what we're doing here in terms of testing?

Can you try to use this example for testing the SensitiveParameter?

https://3v4l.org/Gh1lY

[heap-s]

@Tigrov The solution that I think of implementing is https://3v4l.org/QK6Yo I believe that this is appropriate and what you'd like in terms of testing for the SensitiveParameter. Let me know what you think.

[heap-s]

Let me know if you'd like me to squash these commits, so that the history is cleaner

[Tigrov]

Let me know if you'd like me to squash these commits, so that the history is cleaner

Let's see on test results then squash and merge it.

[Tigrov]

Thanks 👍