Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ArrayColumnSchema and StructuredColumnSchema from db-pgsql #882

Merged
merged 8 commits into from
Oct 8, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Oct 7, 2024

Related PR

Q A
Is bugfix?
New feature? ✔️
Breaks BC? ✔️/❌
Fixed issues #854

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 99.19355% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.56%. Comparing base (49c3a16) to head (155fe1a).

Files with missing lines Patch % Lines
src/Schema/Column/StructuredColumnSchema.php 96.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #882      +/-   ##
============================================
- Coverage     99.58%   99.56%   -0.02%     
- Complexity     1435     1486      +51     
============================================
  Files            77       80       +3     
  Lines          3575     3699     +124     
============================================
+ Hits           3560     3683     +123     
- Misses           15       16       +1     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov added the status:code review The pull request needs review. label Oct 7, 2024
@Tigrov Tigrov requested a review from a team October 7, 2024 13:50
src/Expression/StructuredExpression.php Show resolved Hide resolved
src/Expression/StructuredExpression.php Outdated Show resolved Hide resolved
src/Expression/StructuredExpression.php Outdated Show resolved Hide resolved
@Tigrov Tigrov merged commit 42e1168 into master Oct 8, 2024
3 checks passed
@Tigrov Tigrov deleted the move-array-and-structured branch October 8, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants