Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve psalm annotations in ColumnDefinitionParser #891

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

vjik
Copy link
Member

@vjik vjik commented Oct 18, 2024

Q A
Is bugfix?
New feature?
Breaks BC?

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.60%. Comparing base (d04a9c4) to head (acf6473).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #891   +/-   ##
=========================================
  Coverage     99.60%   99.60%           
  Complexity     1518     1518           
=========================================
  Files            81       81           
  Lines          3753     3753           
=========================================
  Hits           3738     3738           
  Misses           15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik requested a review from a team October 18, 2024 18:58
@vjik vjik added the status:code review The pull request needs review. label Oct 18, 2024
@vjik vjik merged commit 42181e1 into master Oct 18, 2024
58 checks passed
@vjik vjik deleted the improve-psalm branch October 18, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants