Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed schema-providers configuration #608

Closed
wants to merge 2 commits into from

Conversation

msmakouz
Copy link

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
  1. Changed namespaces in the configuration file of the yiisoft/yii-cycle package. Related to: Add cycle/schema-provider package yii-cycle#186
  2. Added stable version of yiisoft/hydrator-validator. To fix dependency installation error:
 Problem 1
    - Root composer.json requires yiisoft/input-http dev-master -> satisfiable by yiisoft/input-http[dev-master].
    - yiisoft/input-http dev-master requires yiisoft/hydrator-validator ^1.0 -> found yiisoft/hydrator-validator[1.0.0] but it conflicts with your root composer.json require (dev-master).
  Problem 2
    - yiisoft/input-http dev-master requires yiisoft/hydrator-validator ^1.0 -> found yiisoft/hydrator-validator[1.0.0] but it conflicts with your root composer.json require (dev-master).
    - yiisoft/yii-gii dev-master requires yiisoft/input-http dev-master -> satisfiable by yiisoft/input-http[dev-master].
    - Root composer.json requires yiisoft/yii-gii dev-master -> satisfiable by yiisoft/yii-gii[dev-master].

Copy link

what-the-diff bot commented Feb 12, 2024

PR Summary

  • Dependency Update in composer.json
    The version of the "yiisoft/hydrator-validator" dependency was updated from a less stable 'development' version to a more robust and stable "^1.0" version. This improves stability and prevents unexpected changes in the future that could potentially break our application's functionality.

  • Namespace and Reference Changes in params.php

    • Namespaces for the PhpFileSchemaProvider and SchemaProviderInterface have been updated to better reflect their actual location in the project. This allows for easier navigation and understanding when working with the code.

    • SchemaProviderPipeline was included using use statement to ease access to it without specifying its full path every time.

    • Documentation comment used to describe the SchemaProviderPipeline was updated to reflect the new namespace.

    • References were updated in commented code for the SimpleCacheSchemaProvider. This change does not currently affect the behaviour of the code, but provides clear and accurate guidance if the commented code is searched or referenced in the future.

    • The reference to PhpFileSchemaProvider in array declaration was updated to its new name fitting its new location.

@samdark
Copy link
Member

samdark commented Feb 12, 2024

Any idea why it fails all the tests?

@msmakouz
Copy link
Author

Any idea why it fails all the tests?

I saw that in the last commit in the master branch they also failed: https://github.com/yiisoft/demo/actions/runs/7457198377/job/20289006750 and did not pay attention to them. I'll take a look.

@msmakouz msmakouz marked this pull request as draft February 12, 2024 12:23
@roxblnfk roxblnfk requested a review from a team February 12, 2024 13:07
@msmakouz
Copy link
Author

Fixed by: #610

@msmakouz msmakouz closed this Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants