Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route attribute #609

Merged
merged 4 commits into from
Feb 20, 2024
Merged

Route attribute #609

merged 4 commits into from
Feb 20, 2024

Conversation

pamparam83
Copy link
Contributor

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

fix tests

Copy link

what-the-diff bot commented Feb 20, 2024

PR Summary

  • Improvement of Command Display
    This PR enhances the readability of the composer run serve command by introducing code highlighting. This will make the command stand out and be easier to locate in the project codebase.

  • Modification of Namespaces
    There have been namespace changes for both PhpFileSchemaProvider and RouteArgument across several files. This has been done to improve code organization and to possibly resolve any underlying issues related to class overlaps or incorrect import statements.

  • Changes in OffsetPagination Widget
    The menuClass property has been taken out from the OffsetPagination widget and the method name isRequired has been changed to the more descriptive isPaginationRequired. These alterations aim to make the code cleaner and its purpose more clear and understandable.

  • Updates in AuthController and UserController
    The method call getAttributeValue is replaced by getPropertyValue in AuthController and a new PageToken class has been added to handle pagination in UserController. Also, the method call withNextPageToken has been amended to withToken in UserController. These changes are made for better accuracy and functionality.

  • Test Annotation Update
    In LoginAcceptanceCest, the @depends annotation was updated, ensuring that software tests execute in the correct order and improving overall test reliability.

@samdark samdark merged commit 9122601 into yiisoft:master Feb 20, 2024
7 of 14 checks passed
@samdark
Copy link
Member

samdark commented Feb 20, 2024

Thanks.

@pamparam83 pamparam83 deleted the route-attribute branch February 21, 2024 16:09
rossaddison added a commit to rossaddison/invoice that referenced this pull request Apr 14, 2024
RouteArgument replaces CurrentRoute

eg.

````
/**
 * @param int $id
 */
    public function delete(#[RouteArgument('id')] int $id
````

replaces

````
public function delete(CurrentRoute $currentRoute) : Response
 {

$id = $currentRoute->getArgument('id');
````
rossaddison added a commit to rossaddison/invoice that referenced this pull request Apr 26, 2024
rossaddison added a commit to rossaddison/invoice that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants