Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when the page number > total pages ,it will cause 500 error #629

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TiaNex-Com
Copy link

when the page number > total pages ,it will cause 500 error , this is a temp fix,

it seems to fix in OffsetPaginator method withCurrentPage will be better,

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues comma-separated list of tickets # fixed by the PR, if any

when the page number > total pages ,it will cause 500 error ,
this is a temp fix,

it seems to fix in OffsetPaginator  method  withCurrentPage  will be better,
@samdark samdark requested a review from vjik October 14, 2024 08:44
@TiaNex-Com
Copy link
Author

it's better to fix in OffsetPaginator method withCurrentPage, won't need to modify other code

@vjik
Copy link
Member

vjik commented Oct 15, 2024

@TiaNex-Com Can you show stack trace of error?

@vjik
Copy link
Member

vjik commented Oct 17, 2024

How about this solution: yiisoft/data#206?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants