Fix

yiisoft · Jul 25, 2023 · 841734b · 841734b
1 parent 34d4814
commit 841734b
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/src/Counter.php b/src/Counter.php
@@ -75,7 +75,7 @@ public function hit(string $id): CounterState
         do {
             // Last increment time.
             // In GCRA it's known as arrival time.
-            $lastIncrementTimeInMilliseconds = $this->timer->now()->format('U.u') * 1000;
+            $lastIncrementTimeInMilliseconds = round($this->timer->now()->format('U.u') * 1000);
 
             $lastStoredTheoreticalNextIncrementTime = $this->getLastStoredTheoreticalNextIncrementTime($id);
 

diff --git a/tests/Storage/ApcuStorageTest.php b/tests/Storage/ApcuStorageTest.php
@@ -35,7 +35,7 @@ public function testSaveIfNotExistsWithExistsKey(): void
     {
         $storage = $this->getStorage();
 
-        $value = (new DateTimeImmutable())->format('U.u') * 1000;
+        $value = round((new DateTimeImmutable())->format('U.u') * 1000);
         $storage->saveIfNotExists('exists_key', $value, self::DEFAULT_TTL);
 
         $result = $storage->saveIfNotExists('exists_key', $value, self::DEFAULT_TTL);
@@ -47,7 +47,7 @@ public function testSaveCompareAndSwapWithNewKey(): void
     {
         $storage = $this->getStorage();
 
-        $newValue = (new DateTimeImmutable())->format('U.u') * 1000;
+        $newValue = round((new DateTimeImmutable())->format('U.u') * 1000);
         $oldValue = (int) $storage->get('new_key');
 
         $result = $storage->saveCompareAndSwap(
@@ -64,7 +64,7 @@ public function testSaveCompareAndSwapWithExistsKeyButOldValueDifferent(): void
     {
         $storage = $this->getStorage();
 
-        $oldValue = (new DateTimeImmutable())->format('U.u') * 1000;
+        $oldValue = round((new DateTimeImmutable())->format('U.u') * 1000);
         $storage->saveIfNotExists('exists_key', $oldValue, self::DEFAULT_TTL);
 
         $oldValue = $oldValue + 200;

diff --git a/tests/Storage/StorageTest.php b/tests/Storage/StorageTest.php
@@ -34,20 +34,20 @@ public function testGetKeyWithExistsKey(): void
     {
         $storage = $this->getStorage();
 
-        $want = (new DateTimeImmutable())->format('U.u') * 1000;
+        $want = round((new DateTimeImmutable())->format('U.u') * 1000);
 
         $storage->saveIfNotExists('exists_key', $want, self::DEFAULT_TTL);
 
         $result = $storage->get('exists_key');
 
-        $this->assertEquals($result, $want);
+        $this->assertEquals($want, $result);
     }
 
     public function testSaveIfNotExistsWithNewKey(): void
     {
         $storage = $this->getStorage();
 
-        $value = (new DateTimeImmutable())->format('U.u') * 1000;
+        $value = round((new DateTimeImmutable())->format('U.u') * 1000);
 
         $result = $storage->saveIfNotExists('new_key', $value, self::DEFAULT_TTL);
 
@@ -58,7 +58,7 @@ public function testSaveCompareAndSwapWithExistsKeyAndOldValueSame(): void
     {
         $storage = $this->getStorage();
 
-        $oldValue = (new DateTimeImmutable())->format('U.u') * 1000;
+        $oldValue = round((new DateTimeImmutable())->format('U.u') * 1000);
         $storage->saveIfNotExists('exists_key', $oldValue, self::DEFAULT_TTL);
 
         $newValue = $oldValue + 100;