Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add str_starts_with support for php 8 #41

Merged
merged 6 commits into from
Sep 29, 2020
Merged

Add str_starts_with support for php 8 #41

merged 6 commits into from
Sep 29, 2020

Conversation

viktorprogger
Copy link
Contributor

Q A
Is bugfix? ❌
New feature? ✔️
Breaks BC? ❌
Fixed issues Fix #40

@viktorprogger viktorprogger requested review from samdark and a team September 4, 2020 14:50
rustamwin
rustamwin approved these changes Sep 4, 2020
View reviewed changes
src/StringHelper.php Outdated Show resolved Hide resolved
@samdark samdark added the status:under development Someone is working on a pull request. label Sep 6, 2020
@viktorprogger @rustamwin
Use FQN for embedded functions
6e816f5 
Co-authored-by: Rustam Mamadaminov <[email protected]>
@viktorprogger viktorprogger added status:code review The pull request needs review. and removed status:under development Someone is working on a pull request. labels Sep 16, 2020
@viktorprogger viktorprogger requested review from rustamwin, xepozz and a team September 16, 2020 15:46
samdark
samdark requested changes Sep 16, 2020
View reviewed changes
Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about str_ends_with()?

tests/StringHelperTest.php Outdated Show resolved Hide resolved
@viktorprogger viktorprogger added status:under development Someone is working on a pull request. and removed status:code review The pull request needs review. labels Sep 17, 2020
@samdark samdark added this to the 1.0.1 milestone Sep 19, 2020
@viktorprogger viktorprogger added status:code review The pull request needs review. and removed status:under development Someone is working on a pull request. labels Sep 25, 2020
samdark
samdark approved these changes Sep 28, 2020
View reviewed changes
Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks great. Since this package has a stable release, we need a CHANGELOG.md with the line describing the change.

@samdark samdark added status:ready for merge The pull request is OK to be merged. and removed status:code review The pull request needs review. labels Sep 28, 2020
@samdark samdark merged commit ae87766 into master Sep 29, 2020
@samdark
Copy link
Member

samdark commented Sep 29, 2020

👍

@samdark samdark deleted the bench_mb_str_starts_with branch September 29, 2020 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

@rustamwin rustamwin Awaiting requested review from rustamwin

@xepozz xepozz Awaiting requested review from xepozz

Assignees
No one assigned
Labels
status:ready for merge The pull request is OK to be merged.
Projects
None yet
Milestone
1.0.1
Development

Successfully merging this pull request may close these issues.

Benchmark if mb_str_starts_with / mb_str_ends_with are worth it for PHP 8
4 participants
@viktorprogger @samdark @xepozz @rustamwin