Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the nullable parameter declarations for compatibility with PHP 8.4 #142

Closed
wants to merge 2 commits into from

Conversation

martio
Copy link
Contributor

@martio martio commented Dec 25, 2024

Q A
Is bugfix? ✅/✖️
New feature? ✔️/❌
Breaks BC? ✔️/❌
Fixed issues comma-separated list of tickets # fixed by the PR, if any

I have prepared a small fix that resolves the following issue:

DEPRECATED  Yiisoft\Translator\TranslatorInterface::translate(): Implicitly marking parameter $locale as nullable is deprecated, the explicit nullable type must be used instead in vendor/yiisoft/translator/src/TranslatorInterface.php on line 46.

Yiisoft\Translator\TranslatorInterface

   public function translate(
       string|Stringable $id,
       array $parameters = [],
       string $category = null,
       string $locale = null
   ): string;

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.35%. Comparing base (50dcaa5) to head (cbbe39c).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #142   +/-   ##
=========================================
  Coverage     99.35%   99.35%           
  Complexity      111      111           
=========================================
  Files            13       13           
  Lines           308      308           
=========================================
  Hits            306      306           
  Misses            2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samdark
Copy link
Member

samdark commented Dec 25, 2024

Please add a line to CHANGELOG.

@martio martio closed this by deleting the head repository Dec 25, 2024
@martio
Copy link
Contributor Author

martio commented Dec 25, 2024

@samdark I'm sorry, I thought it had already been merged, so I deleted the fork. I have created it again. Best regards! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants