Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise minimal version PHP to 8.1 + Remove scrutinizer #135

Merged
merged 3 commits into from
Feb 18, 2024
Merged

Conversation

vjik
Copy link
Member

@vjik vjik commented Feb 18, 2024

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues comma-separated list of tickets # fixed by the PR, if any

@vjik vjik changed the title Raise minimal version PHP to 8.1 Raise minimal version PHP to 8.1 + Remove scrutinizer Feb 18, 2024
Copy link

what-the-diff bot commented Feb 18, 2024

PR Summary

  • Enhanced Github Workflows

    • Introduced the "push" event for the 'master' branch in several Github workflows, improving the speed and efficiency of continuous integration (CI) builds.
  • Removed Scrutinizer Configuration

    • Deleted the .scrutinizer.yml configuration file, no longer relying on the Scrutinizer service for code quality analysis.
  • Updated PHP Requirements

    • Elevates the PHP version requirement from 7.4/8.0 to 8.1 in multiple files, ensuring the software uses the newest features of PHP for better performance and security.
  • Refined Rector Rules

    • Enhanced code transformation rules and bypassed the application of some existing rules in the rector.php file, leading to a more efficient automated code upgrade process.
  • Modified Composer Class

    • Altered the arrow function in Composer class in GitController.php, which likely optimizes some specific process in the application's Git interactions.

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3cb1489) 3.56% compared to head (7625b24) 3.56%.

Files Patch % Lines
src/Inspector/Controller/GitController.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             master    #135   +/-   ##
========================================
  Coverage      3.56%   3.56%           
  Complexity      254     254           
========================================
  Files            22      22           
  Lines          1122    1122           
========================================
  Hits             40      40           
  Misses         1082    1082           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik added the status:code review The pull request needs review. label Feb 18, 2024
@vjik vjik requested a review from a team February 18, 2024 14:32
@samdark samdark merged commit 1a9ff6a into master Feb 18, 2024
16 of 18 checks passed
@samdark samdark deleted the php81 branch February 18, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants