Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create symbol links only target packages #230

Merged
merged 3 commits into from
Oct 3, 2022
Merged

Conversation

DAGpro
Copy link
Contributor

@DAGpro DAGpro commented Sep 24, 2022

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues #166 #142

@samdark
Copy link
Member

samdark commented Sep 25, 2022

Would you please resolve conflicts?

@DAGpro
Copy link
Contributor Author

DAGpro commented Sep 25, 2022

Would you please resolve conflicts?

Done

@DAGpro
Copy link
Contributor Author

DAGpro commented Sep 25, 2022

This pull request addresses issue #164 in the install, update, and composer/update commands?

@samdark samdark merged commit bff68ec into yiisoft:master Oct 3, 2022
@DAGpro DAGpro deleted the relinks-2 branch October 6, 2022 22:49
xepozz added a commit that referenced this pull request Oct 14, 2022
@xepozz
Copy link
Member

xepozz commented Oct 14, 2022

That broke at least update and install commands

@DAGpro
Copy link
Contributor Author

DAGpro commented Oct 14, 2022

That broke at least update and install commands

more details

@xepozz
Copy link
Member

xepozz commented Oct 14, 2022

Have you tried the code in a action?

@DAGpro
Copy link
Contributor Author

DAGpro commented Oct 14, 2022

Have you tried the code in a action?

Yes

used powershell in windows

checked the list of created symbolic links with the command
Dir working-directory -Force -Recurse | ?{$_.LinkType} | select FullName,LinkType,Target

@xepozz
Copy link
Member

xepozz commented Oct 15, 2022

I meant commands ./yii-dev install and ./yii-dev update

@DAGpro
Copy link
Contributor Author

DAGpro commented Oct 15, 2022

Я имел в виду команды ./yii-dev installи./yii-dev update

I understand.
Executed installation and update commands and checked the list of created links that everything works.

Can you already give more details, what doesn't work for you, commands don't run at all? 😒

@DAGpro
Copy link
Contributor Author

DAGpro commented Oct 15, 2022

@xepozz Either not all links are created or the package name does not match the composer name?

@xepozz
Copy link
Member

xepozz commented Oct 15, 2022

Maybe later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants