Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yiisoft/yii2#20202 #350

Merged
merged 6 commits into from
Jun 19, 2024
Merged

Fix yiisoft/yii2#20202 #350

merged 6 commits into from
Jun 19, 2024

Conversation

lav45
Copy link
Contributor

@lav45 lav45 commented Jun 15, 2024

Q A
Is bugfix? ✔️
New feature?
Breaks BC? ✔️
Fixed issues yiisoft/yii2#20202

@samdark
Copy link
Member

samdark commented Jun 16, 2024

It will just install older version. It's better to fix the reason for such behavior.

@lav45
Copy link
Contributor Author

lav45 commented Jun 16, 2024

@samdark I fixed the error, but the build still doesn't work. Also, we need to somehow reconcile the versions of yii2-elasticsearch and yii2, but I don't yet understand how. yii2:2.0.50 works with php>=7.4, while yii2-elasticsearch requires php>=5.6.

@terabytesoftw
Copy link
Member

@samdark I fixed the error, but the build still doesn't work. Also, we need to somehow reconcile the versions of yii2-elasticsearch and yii2, but I don't yet understand how. yii2:2.0.50 works with php>=7.4, while yii2-elasticsearch requires php>=5.6.

#346 review this pr.

@samdark
Copy link
Member

samdark commented Jun 16, 2024

@terabytesoftw merged. @lav45 can you resolve conflicts please?

@terabytesoftw
Copy link
Member

terabytesoftw commented Jun 17, 2024

I can confirm that the latest ActiveDataProvider::class in Yii2 change resolves the segmentation issue in ElasticSearch.

https://github.com/terabytesoftw/yii2-elasticsearch/actions/runs/9546397753/job/26309179454

@samdark
Copy link
Member

samdark commented Jun 17, 2024

@terabytesoftw you mean this PR isn't needed?

@terabytesoftw
Copy link
Member

@terabytesoftw you mean this PR isn't needed?

I'm saying that now the fix works with yiisoft/yii2#20206

@samdark
Copy link
Member

samdark commented Jun 17, 2024

@terabytesoftw seems elastic search doesn't build anymore :(

@samdark
Copy link
Member

samdark commented Jun 18, 2024

@lav45 can you add a line for CHANGELOG? Thanks.

@samdark samdark merged commit 498a28d into yiisoft:master Jun 19, 2024
@samdark
Copy link
Member

samdark commented Jun 19, 2024

Thank you!

@samdark samdark added this to the 2.1.5 milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants