Adding the ability to run tests on PHP 8.0 #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
s1lver
commented
Feb 17, 2023
s1lver
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
| Fixed issues |
|
|
|
Looks like I'll have to forget about tests for php 8.0 and php 8.1. Tests and components are tied to 5.6. Now there is a problem in a component that appears on 8.0/8.1, but no tests can be written( |
|
Hmm... That's weird. If it works with 8.0 and 8.1 then that's dev-dependencies that aren't resolvable, right? |
samdark
reviewed
Feb 21, 2023
Co-authored-by: Alexander Makarov <[email protected]>
samdark
reviewed
May 18, 2023
# Conflicts: # composer.json
|
Now new fluky test with priority in php 8.0 |
terabytesoftw
approved these changes
Sep 28, 2023
|
👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.