Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Beanstalk driver to version 5 #498

Merged
merged 9 commits into from
Oct 20, 2023
Merged

Updated Beanstalk driver to version 5 #498

merged 9 commits into from
Oct 20, 2023

Conversation

s1lver
Copy link
Member

@s1lver s1lver commented Oct 19, 2023

Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ✔️
Fixed issues #357

@codecov
Copy link

codecov bot commented Oct 19, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (3.0@136d998). Click here to learn what that means.

❗ Current head 780b8d3 differs from pull request most recent head 14b28bc. Consider uploading reports for the commit 14b28bc to get more accurate results

Additional details and impacted files 
@@          Coverage Diff           @@
##             3.0     #498   +/-   ##
======================================
  Coverage       ?   28.36%           
  Complexity     ?      473           
======================================
  Files          ?       45           
  Lines          ?     1636           
  Branches       ?        0           
======================================
  Hits           ?      464           
  Misses         ?     1172           
  Partials       ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bizley
bizley requested changes Oct 19, 2023
View reviewed changes
src/drivers/beanstalk/Queue.php Outdated Show resolved Hide resolved
src/drivers/beanstalk/Queue.php Outdated Show resolved Hide resolved
tests/drivers/beanstalk/QueueTest.php Outdated Show resolved Hide resolved
@s1lver s1lver requested a review from bizley October 19, 2023 12:31
@samdark samdark added this to the 2.3.7 milestone Oct 19, 2023
samdark
samdark approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a line for CHANGELOG. Thanks.

@s1lver s1lver removed this from the 2.3.7 milestone Oct 20, 2023
@s1lver s1lver merged commit bd3ce76 into 3.0 Oct 20, 2023
4 checks passed
@s1lver s1lver deleted the beanstalk branch October 20, 2023 13:32
@s1lver s1lver added this to the 3.0.0 milestone Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

@terabytesoftw terabytesoftw terabytesoftw approved these changes

@bizley bizley Awaiting requested review from bizley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@s1lver @samdark @bizley @terabytesoftw