-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add methods to normalize tag attributes in Html helper #19100
base: master
Are you sure you want to change the base?
Conversation
Thank you for putting effort in the improvement of the Yii framework. Unfortunately a use case is missing. It is required to get a better understanding of the pull request and helps us to determine the necessity and applicability of the suggested change to the framework. Could you supply us with a use case please? Please be as detailed as possible and show some code! Thanks! This is an automated comment, triggered by adding the label |
Converts attribute arrays to unified style: data/custom, style, class attributes converts to array. For example, if we replace |
@yii-bot need review |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19100 +/- ##
============================================
- Coverage 22.16% 19.58% -2.58%
- Complexity 11386 11408 +22
============================================
Files 430 430
Lines 37113 37150 +37
============================================
- Hits 8225 7277 -948
- Misses 28888 29873 +985 ☔ View full report in Codecov by Sentry. |
Converts values of style, class, custom attributes to arrays to fix invalid merging attributes in widgets.