Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for setCookieParams #19921

Merged
merged 1 commit into from
Jul 30, 2023
Merged

Update documentation for setCookieParams #19921

merged 1 commit into from
Jul 30, 2023

Conversation

clemens-it
Copy link
Contributor

The link for more information about "sameSite" lead to a 404 Not Found.

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues

The link for more information about "sameSite" lead to a 404 Not Found.
@what-the-diff
Copy link

what-the-diff bot commented Jul 29, 2023

PR Summary

  • Updated Reference Link in Comments
    The hyperlink in the comments section providing reference guidance has been updated. Previously the link directed to an outdated or incorrect page. Now it directs to the correct information source on the OWASP'S SameSite feature.

@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8a21331) 48.89% compared to head (bc38055) 48.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #19921   +/-   ##
=======================================
  Coverage   48.89%   48.89%           
=======================================
  Files         445      445           
  Lines       42786    42786           
=======================================
  Hits        20919    20919           
  Misses      21867    21867           
Files Changed Coverage Δ
framework/web/Session.php 41.12% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bizley bizley merged commit 504a66d into yiisoft:master Jul 30, 2023
49 checks passed
@bizley bizley added the type:docs Documentation label Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:docs Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants