-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate tests in CI. #19952
Conversation
terabytesoftw
commented
Sep 13, 2023
Q | A |
---|---|
Is bugfix? | ✔️ |
New feature? | ❌ |
Breaks BC? | ❌ |
PR Summary
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #19952 +/- ##
==========================================
- Coverage 48.95% 48.94% -0.02%
==========================================
Files 445 445
Lines 42807 42817 +10
==========================================
- Hits 20957 20956 -1
- Misses 21850 21861 +11
☔ View full report in Codecov by Sentry. |
With this latest modification, it will work correctly by eliminating double This should cut the number of workers and test time in half. It will also not run tests when modifying these files:
Note: Duplication occurs when you do the PR without a Fork, when the maintainers do it directly to the repository, when you do it from a Pull Request, it works correctly, if you always use Fork, then this PR is not necessary. |
@terabytesoftw can we merge it or does it require more work? |
Let's wait better, try it some more. |
@terabytesoftw enough time passed? |
After reviewing well, it is not necessary, all the PR in Yii2 come from a fork, so it is not a problem. |
I'm wandering, can we only execute ci-node on js changed |