Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate tests in CI. #19952

Closed
wants to merge 2 commits into from
Closed

Remove duplicate tests in CI. #19952

wants to merge 2 commits into from

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

@what-the-diff
Copy link

what-the-diff bot commented Sep 13, 2023

PR Summary

  • Enhancement of Several Workflow Configurations
    This update involves adjusting various build workflows, including ci-mssql, ci-mysql, ci-node, ci-oracle, ci-pgsql, and ci-sqlite. The improvement comes by adding a "paths-ignore" feature to these workflow configurations. This means, during pull-request and push events, certain paths specified by us will be ignored. The benefit of this is that it allows for more focus on areas of the code that are more relevant to the change being made, reducing unnecessary build time and resources.

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (4ffb58e) 48.95% compared to head (1a9dd7f) 48.94%.
Report is 28 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19952      +/-   ##
==========================================
- Coverage   48.95%   48.94%   -0.02%     
==========================================
  Files         445      445              
  Lines       42807    42817      +10     
==========================================
- Hits        20957    20956       -1     
- Misses      21850    21861      +11     
Files Coverage Δ
framework/BaseYii.php 88.33% <100.00%> (ø)
framework/db/BaseActiveRecord.php 77.58% <ø> (ø)
framework/db/Migration.php 16.66% <ø> (ø)
framework/helpers/mimeExtensions.php 0.08% <0.00%> (-0.01%) ⬇️
framework/helpers/mimeTypes.php 0.30% <0.00%> (-0.01%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schmunk42 schmunk42 self-assigned this Sep 13, 2023
@terabytesoftw
Copy link
Member Author

terabytesoftw commented Oct 5, 2023

With this latest modification, it will work correctly by eliminating double worflows for pull requests. Additionally, it runs the workflows in the fork, and only pushes to the master branch.

This should cut the number of workers and test time in half.

It will also not run tests when modifying these files:

  • 'docs/**'
  • 'README.md'
  • 'CHANGELOG.md'
  • '.gitignore'
  • '.gitattributes'

Note: Duplication occurs when you do the PR without a Fork, when the maintainers do it directly to the repository, when you do it from a Pull Request, it works correctly, if you always use Fork, then this PR is not necessary.

@bizley
Copy link
Member

bizley commented Oct 5, 2023

@terabytesoftw can we merge it or does it require more work?

@terabytesoftw
Copy link
Member Author

@terabytesoftw can we merge it or does it require more work?

Let's wait better, try it some more.

@samdark
Copy link
Member

samdark commented Oct 19, 2023

@terabytesoftw enough time passed?

@terabytesoftw
Copy link
Member Author

After reviewing well, it is not necessary, all the PR in Yii2 come from a fork, so it is not a problem.

@terabytesoftw terabytesoftw deleted the update-workflows branch October 19, 2023 17:23
@xicond
Copy link
Contributor

xicond commented Oct 20, 2023

I'm wandering, can we only execute ci-node on js changed
a job intermittently failed 17871509197 while I'm not changing js #20007

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants