Bug #18469: fix Link::serialize method #20020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #20020 +/- ##
==========================================
- Coverage 48.02% 48.02% -0.01%
==========================================
Files 445 445
Lines 43890 43889 -1
==========================================
- Hits 21078 21077 -1
Misses 22812 22812 ☔ View full report in Codecov by Sentry. |
bizley
reviewed
Oct 23, 2023
framework/web/Link.php
Outdated
| @@ -66,7 +66,11 @@ public static function serialize(array $links) | |||
| $link[$i] = $l instanceof self ? array_filter((array) $l) : ['href' => $l]; | |||
| } | |||
| $links[$rel] = $link; | |||
| } elseif (!$link instanceof self) { | |||
| } | |||
| if ($link instanceof self) { | |||
There was a problem hiding this comment.
Let's refactor this method to a recursive call instead.
There was a problem hiding this comment.
Are you referring to line 66(or maybe the whole method)?
I'd replace the second loop with this recursive call $link = self::serialize($link); in order to remove it
|
It is only me, or these test do not have sense at all? :P |
|
Yep, I can refactor the tests to avoid confusion. |
|
@bizley is it fine now? |
bizley
requested changes
Nov 13, 2023
bizley
approved these changes
Nov 18, 2023
Arhell
approved these changes
Nov 19, 2023
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I applied the fix proposed above with some unit tests. Hope it helps