Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of handling ErrorHandler::$memoryReserveSize #20033

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Improve performance of handling ErrorHandler::$memoryReserveSize #20033

merged 1 commit into from
Oct 23, 2023

Conversation

rob006
Copy link
Contributor

@rob006 rob006 commented Oct 23, 2023

Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ❌
Fixed issues #20032

fix #20030

@rob006 rob006 mentioned this pull request Oct 23, 2023
Closed
@codecov
Copy link

codecov bot commented Oct 23, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c9ac82d) 47.49% compared to head (2141f9a) 47.49%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #20033   +/-   ##
=======================================
  Coverage   47.49%   47.49%           
=======================================
  Files         445      445           
  Lines       43384    43384           
=======================================
  Hits        20604    20604           
  Misses      22780    22780
Files Coverage Δ
framework/base/ErrorHandler.php 7.79% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rob006
Copy link
Contributor Author

rob006 commented Oct 23, 2023

"benchmark": https://3v4l.org/GQmMB

@bizley bizley added this to the 2.0.50 milestone Oct 23, 2023
@bizley bizley merged commit 80f465a into yiisoft:master Oct 23, 2023
49 of 50 checks passed
@rob006 rob006 deleted the error-handler branch October 23, 2023 21:11
@samdark
Copy link
Member

samdark commented Oct 24, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type:enhancement
Projects
None yet
Milestone
2.0.50
Development

Successfully merging this pull request may close these issues.

Increased response time when increasing the value in ErrorHandler::memoryReserveSize
3 participants
@rob006 @samdark @bizley