Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen htmlpurifier version #20081

Closed
wants to merge 1 commit into from
Closed

Conversation

machour
Copy link
Member

@machour machour commented Dec 12, 2023

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues #20080

Copy link

what-the-diff bot commented Dec 12, 2023

PR Summary

  • Updated Version Constraint for ezyang/htmlpurifier
    The rule set for the version of the ezyang/htmlpurifier package that can be used in this project has been updated. Previously, it was set to accept only specific versions (4.6). But now, it has been changed to accept any versions that are 4.6 or higher. This makes our system more flexible and adaptable to new updates from this package.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d43341a) 48.02% compared to head (e0b7e61) 47.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20081      +/-   ##
==========================================
- Coverage   48.02%   47.56%   -0.46%     
==========================================
  Files         445      445              
  Lines       43889    43407     -482     
==========================================
- Hits        21077    20647     -430     
+ Misses      22812    22760      -52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -73,7 +73,7 @@
"ext-ctype": "*",
"lib-pcre": "*",
"yiisoft/yii2-composer": "~2.0.4",
"ezyang/htmlpurifier": "^4.6",
"ezyang/htmlpurifier": ">=4.6",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an unbound version constraint and should be avoided.
Which version would you need?

^4.6 would install 4.17 btw: https://semver.madewithlove.com/?package=ezyang%2Fhtmlpurifier&constraint=%5E4.6

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need 4.7 to get installed (and a coffee obviously)

@machour
Copy link
Member Author

machour commented Dec 12, 2023

Sorry for the noise, my troubles were caused by phpoffice/phpspreadsheet

@machour machour closed this Dec 12, 2023
@machour machour deleted the 83-htmlpurifier branch December 12, 2023 09:26
@terabytesoftw
Copy link
Member

Sorry for the noise, my troubles were caused by phpoffice/phpspreadsheet

No problem, nice to hear from you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants