-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loosen htmlpurifier version #20081
Loosen htmlpurifier version #20081
Conversation
machour
commented
Dec 12, 2023
Q | A |
---|---|
Is bugfix? | ✔️ |
New feature? | ❌ |
Breaks BC? | ❌ |
Fixed issues | #20080 |
PR Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20081 +/- ##
==========================================
- Coverage 48.02% 47.56% -0.46%
==========================================
Files 445 445
Lines 43889 43407 -482
==========================================
- Hits 21077 20647 -430
+ Misses 22812 22760 -52 ☔ View full report in Codecov by Sentry. |
@@ -73,7 +73,7 @@ | |||
"ext-ctype": "*", | |||
"lib-pcre": "*", | |||
"yiisoft/yii2-composer": "~2.0.4", | |||
"ezyang/htmlpurifier": "^4.6", | |||
"ezyang/htmlpurifier": ">=4.6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an unbound version constraint and should be avoided.
Which version would you need?
^4.6
would install 4.17
btw: https://semver.madewithlove.com/?package=ezyang%2Fhtmlpurifier&constraint=%5E4.6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need 4.7 to get installed (and a coffee obviously)
Sorry for the noise, my troubles were caused by phpoffice/phpspreadsheet |
No problem, nice to hear from you. |