Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #20191 #20192

Merged
merged 4 commits into from
Jun 8, 2024
Merged

Fix #20191 #20192

merged 4 commits into from
Jun 8, 2024

Conversation

brandonkelly
Copy link
Contributor

Fixes #20191 by only sorting associative arrays when comparing old/new array column values, recursively.

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues #20191

@samdark
Copy link
Member

samdark commented Jun 7, 2024

@brandonkelly would you please add a line for CHANGELOG? Thanks.

@schmunk42
Copy link
Contributor

Don't we need a test for this?

@brandonkelly
Copy link
Contributor Author

@samdark Release note added.

@schmunk42 Test case added. Confirmed it fails on master and passes with my fix in place.

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.97%. Comparing base (f1ac78f) to head (634f918).
Report is 1 commits behind head on master.

Current head 634f918 differs from pull request most recent head 08922e3

Please upload reports for the commit 08922e3 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #20192   +/-   ##
=========================================
  Coverage     64.97%   64.97%           
  Complexity    11388    11388           
=========================================
  Files           430      430           
  Lines         36908    36912    +4     
=========================================
+ Hits          23981    23985    +4     
  Misses        12927    12927           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samdark samdark merged commit 048eef4 into yiisoft:master Jun 8, 2024
68 of 70 checks passed
@samdark
Copy link
Member

samdark commented Jun 8, 2024

Thanks!

@brandonkelly brandonkelly deleted the 20191-fix branch June 12, 2024 15:23
brandonkelly added a commit to craftcms/cms that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ActiveRecord::getDirtyAttributes() not working for JSON columns with multi-dimensional arrays
6 participants