-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #20191 #20192
Fix #20191 #20192
Conversation
@brandonkelly would you please add a line for CHANGELOG? Thanks. |
Don't we need a test for this? |
[ci skip]
@samdark Release note added. @schmunk42 Test case added. Confirmed it fails on |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20192 +/- ##
=========================================
Coverage 64.97% 64.97%
Complexity 11388 11388
=========================================
Files 430 430
Lines 36908 36912 +4
=========================================
+ Hits 23981 23985 +4
Misses 12927 12927 ☔ View full report in Codecov by Sentry. |
Thanks! |
No longer needed thanks to yiisoft/yii2#20192 (see #15154)
Fixes #20191 by only sorting associative arrays when comparing old/new array column values, recursively.