Fix \yii\filters\Cors::actions when attached to a module #20230
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attached to a module (vs a controller),
\yii\filters\Cors::actions
should use the ID defined by\yii\base\ActionFilter::getActionId
, so that the controller ID is included.The
AuthMethod
already does this properly: https://github.com/yiisoft/yii2/blob/master/framework/filters/auth/AuthMethod.php#L106