-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attach behavior via "as behaviorName" with Closure #20248
Merged
mtangoo
merged 6 commits into
yiisoft:master
from
timkelty:feature/attach-behaviors-with-closure
Sep 26, 2024
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
cc05f92
Attach behavior via "as foo" with Closure
timkelty be3d8ef
Fix attachBehavior test
timkelty ff60985
CS fixes
timkelty 2d38497
Revert "CS fixes"
timkelty d9116d3
Merge branch 'master' into feature/attach-behaviors-with-closure
timkelty 8724ba3
Changelog
timkelty File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -328,22 +328,26 @@ public function testAttachBehavior() | |
$this->assertTrue($component->hasProperty('p')); | ||
$component->test(); | ||
$this->assertTrue($component->behaviorCalled); | ||
} | ||
|
||
$this->assertSame($behavior, $component->detachBehavior('a')); | ||
$this->assertFalse($component->hasProperty('p')); | ||
$this->expectException('yii\base\UnknownMethodException'); | ||
$component->test(); | ||
|
||
$p = 'as b'; | ||
public function testAs() | ||
{ | ||
$component = new NewComponent(); | ||
$component->$p = ['class' => 'NewBehavior']; | ||
$this->assertSame($behavior, $component->getBehavior('a')); | ||
$component->{'as a'} = new NewBehavior(); | ||
$this->assertTrue($component->hasProperty('p')); | ||
$component->test(); | ||
$this->assertTrue($component->behaviorCalled); | ||
|
||
$component->{'as b'} = ['class' => NewBehavior::class]; | ||
$this->assertNotNull($component->getBehavior('b')); | ||
|
||
$component->{'as c'} = ['__class' => NewBehavior::class]; | ||
$this->assertNotNull($component->getBehavior('c')); | ||
|
||
$component->{'as d'} = function () { | ||
return new NewBehavior(); | ||
}; | ||
$this->assertNotNull($component->getBehavior('d')); | ||
} | ||
|
||
public function testAttachBehaviors() | ||
|
@@ -376,6 +380,9 @@ public function testDetachBehavior() | |
|
||
$detachedBehavior = $component->detachBehavior('z'); | ||
$this->assertNull($detachedBehavior); | ||
|
||
$this->expectException('yii\base\UnknownMethodException'); | ||
$component->test(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This made more sense to test here than in |
||
} | ||
|
||
public function testDetachBehaviors() | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test was passing but the assertions following this were never run.