Fix #20276: Removed autogenerated migration phpdoc #20276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bizley
approved these changes
Nov 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20276 +/- ##
=========================================
Coverage 64.84% 64.84%
Complexity 11399 11399
=========================================
Files 430 430
Lines 37137 37134 -3
=========================================
Hits 24080 24080
+ Misses 13057 13054 -3 ☔ View full report in Codecov by Sentry. |
|
a duplicate declaration of the class name is meaningless because the class name already tells the developer what kind of class it is |
userator
force-pushed
the
improved-autogenerated-migration-comment
branch
from
8296c2d
to
d47845c
Compare
xepozz
approved these changes
Nov 8, 2024
samdark
requested changes
Nov 8, 2024
userator
force-pushed
the
improved-autogenerated-migration-comment
branch
from
d47845c
to
bf3be9d
Compare
samdark
approved these changes
Nov 11, 2024
|
All good 👍 Please add a line to CHANGELOG. |
|
@samdark fixed, line added to CHANGELOG. |
userator
force-pushed
the
improved-autogenerated-migration-comment
branch
from
bf3be9d
to
cd24009
Compare
samdark
changed the title
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When renaming a class using automated tools (IDE), the class name in the comment is ignored and remains in its original form, which misleads the developer.
relevant for versions 2.2 and 2.0