Skip to content

Commit

Permalink
refactor: update action name
Browse files Browse the repository at this point in the history
  • Loading branch information
yilanboy committed Jul 11, 2024
1 parent f2d9146 commit 1855ef6
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 20 deletions.
14 changes: 7 additions & 7 deletions .github/actions/publish-to-docker-hub/action.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Login to Docker Hub
name: Push Image to Docker Hub

description: A GitHub Action to login to Docker Hub
description: A composite action to push image to docker hub

inputs:
registry_username:
Expand All @@ -10,7 +10,7 @@ inputs:
description: “Password for image registry”
required: true
file:
description: “Path to the Dockerfile to build”
description: “Path to the dockerfile to build”
required: true
platforms:
description: “Platforms to build for”
Expand All @@ -25,13 +25,13 @@ inputs:
runs:
using: "composite"
steps:
- name: Set up QEMU
- name: Set up qemu
uses: docker/setup-qemu-action@v3

- name: Set up Docker Buildx
- name: Set up docker buildx
uses: docker/setup-buildx-action@v3

- name: Login to Docker Hub
- name: Login to docker hub
uses: docker/login-action@v3
with:
username: ${{ inputs.registry_username }}
Expand All @@ -40,7 +40,7 @@ runs:
- name: Build and push image to Docker Hub
uses: docker/build-push-action@v5
with:
file: ${{ inputs.file }}
file: ${{ inputs.file }}
platforms: ${{ inputs.platforms }}
push: true
tags: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-images.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Build images
name: Build Docker Images

on:
push:
Expand Down
13 changes: 6 additions & 7 deletions .github/workflows/lambda-deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,23 +14,22 @@ jobs:
deploy-lambda:
if: ${{ github.event.workflow_run.conclusion == 'success' }}
environment: production
name: Deploy to AWS Lambda
name: Deploy to aws lambda
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4

- name: Configure PHP 8.3
- name: Configure php 8.3
uses: shivammathur/setup-php@v2
with:
php-version: 8.3
extensions: redis
coverage: none

- name: Install php packages
run: composer install --prefer-dist --optimize-autoloader --no-dev

- name: Set up Node.js
- name: Set up node.js
uses: actions/setup-node@v2
with:
node-version: '21'
Expand All @@ -40,17 +39,17 @@ jobs:
npm install
npm run build
- name: Configure AWS credentials
- name: Configure aws credentials
uses: aws-actions/configure-aws-credentials@v4
with:
role-to-assume: arn:aws:iam::154471991214:role/github_action
aws-region: ap-northeast-1

- name: Copy files to the S3 with the AWS CLI
- name: Copy files to the s3 with the aws cli
run: |
aws s3 sync public s3://assets.docfunc.com
- name: Deploy to AWS Lambda
- name: Deploy to aws lambda
run: |
npm install serverless serverless-lift
node_modules/.bin/serverless deploy --stage production
10 changes: 5 additions & 5 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Run tests
name: Run Tests

on:
workflow_dispatch:
Expand Down Expand Up @@ -54,21 +54,21 @@ jobs:
- name: Checkout
uses: actions/checkout@v4

- name: Generate Vite manifest
- name: Generate vite manifest
run: |
npm install
npm run build
# Docs: https://github.com/shivammathur/setup-php
- name: Setup PHP
- name: Setup php
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php }}
# https://laravel.com/docs/9.x/deployment#server-requirements
extensions: redis
coverage: xdebug

- name: Get Composer Cache Directory
- name: Get composer cache directory
id: composer-cache
run: |
echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
Expand Down Expand Up @@ -96,7 +96,7 @@ jobs:
env:
REDIS_PORT: ${{ job.services.redis.ports['6379'] }}

- name: Upload to Codecov
- name: Upload to codecov
uses: codecov/codecov-action@v2
with:
files: ./coverage.xml
Expand Down
1 change: 1 addition & 0 deletions serverless.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ provider:
logRetentionInDays: 1

environment:
MAINTENANCE_MODE: ${param:maintenance, 0}
# App settings
APP_NAME: DocFunc
APP_ENV: production # Or use ${sls:stage} if you want the environment to match the stage
Expand Down

0 comments on commit 1855ef6

Please sign in to comment.