refactor: remove unnecessary code

yilanboy · Mar 6, 2024 · b49c7ed · b49c7ed
1 parent 6a1e2c5
commit b49c7ed
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 15 deletions.
diff --git a/resources/ts/scroll-to-top-btn.ts b/resources/ts/scroll-to-top-btn.ts
@@ -12,32 +12,39 @@ window.setupScrollToTopButton = function (
 ): void {
     scrollToTopButton.addEventListener('click', scrollToTop);
 
-    // 監聽滾動
-    window.addEventListener('scroll', () => {
-        if (window.scrollY > 0) {
-            scrollToTopButton.classList.add('xl:flex');
-        } else {
-            scrollToTopButton.classList.remove('xl:flex');
-        }
-    });
-
+    let header = <HTMLElement>document.getElementById('header');
     let footer = <HTMLElement>document.getElementById('footer');
 
+    // 根據 header 是否出現在畫面上調整按鈕的樣式
+    let headerObserver = new IntersectionObserver(
+        function (entries) {
+            if (entries[0].isIntersecting) {
+                // header 在畫面上
+                scrollToTopButton.classList.remove('xl:flex');
+            } else {
+                // header 不在畫面上
+                scrollToTopButton.classList.add('xl:flex');
+            }
+        },
+        { threshold: [0] },
+    );
+
     // 根據 footer 是否出現在畫面上調整按鈕的樣式
     let footerObserver = new IntersectionObserver(
         function (entries) {
             if (entries[0].isIntersecting) {
                 // footer 在畫面上
-                scrollToTopButton.classList.remove('fixed');
-                scrollToTopButton.classList.add('absolute');
+                scrollToTopButton.classList.remove('fixed', 'bottom-7');
+                scrollToTopButton.classList.add('absolute', 'bottom-1');
             } else {
                 // footer 不在畫面上
-                scrollToTopButton.classList.add('fixed');
-                scrollToTopButton.classList.remove('absolute');
+                scrollToTopButton.classList.add('fixed', 'bottom-7');
+                scrollToTopButton.classList.remove('absolute', 'bottom-1');
             }
         },
         { threshold: [0] },
     );
 
+    headerObserver.observe(header);
     footerObserver.observe(footer);
 };
diff --git a/resources/views/components/post-form/ckedtior.blade.php b/resources/views/components/post-form/ckedtior.blade.php
@@ -8,8 +8,8 @@
       editorDebounceTimer: null,
       debounce(callback, time) {
         // https://webdesign.tutsplus.com/tutorials/javascript-debounce-and-throttle--cms-36783
-        window.clearTimeout(this.editorDebounceTimer);
-        this.editorDebounceTimer = window.setTimeout(callback, time);
+        clearTimeout(this.editorDebounceTimer);
+        this.editorDebounceTimer = setTimeout(callback, time);
       },
       imageUploadUrl: @js(route('images.store')),
       body: @entangle($model).live,