Make the rails enum integration aware of the original type #311
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the
:literal_enum
attribute type, type-aware of the attribute that it is replacing.Additionally it adds a
literal_enum
macro toActiveRecord::Base
that delegates toattribute
and figures out the underlying attribute type.My concern here is with calling
type_for_attribute
at class evaluation time is going to trigger a connection to the DB. This change broke my reproduction script because I created the database after defining the model. But this change makes the model definition require the database to be set up already.Unfortunately I don't think we can lazy evaluate the
type_for_attribute
because after the call toattribute
it's type will have changed to:literal_enum
.