Enable base_unittests and net_unittests. (youtube#463)

- Fix the GLog implementation to use SB_LOG instead of std::cerr. b/273820939
yjzhang111 · May 26, 2023 · e483010 · e483010
1 parent e6dc1db
commit e483010
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 23 deletions.
diff --git a/starboard/evergreen/arm/shared/cobalt/configuration.py b/starboard/evergreen/arm/shared/cobalt/configuration.py
@@ -66,14 +66,4 @@ def GetTestEnvVariables(self):
         'PixelTest.CircularSubPixelBorder',
         'PixelTest.FilterBlurred100PxText',
     ],
-    # These unittest cases are failing after llvm rebase. They will be fixed
-    # and re-enabled.
-    'base_unittests': [
-        '*',
-    ],
-    # These unittest cases are failing after llvm rebase. They will be fixed
-    # and re-enabled.
-    'net_unittests': [
-        '*',
-    ],
   }
diff --git a/starboard/evergreen/x64/cobalt/configuration.py b/starboard/evergreen/x64/cobalt/configuration.py
@@ -39,15 +39,4 @@ def GetTestEnvVariables(self):
         }
     }
 
-  __FILTERED_TESTS = {  # pylint: disable=invalid-name
-    # These unittest cases are failing after llvm rebase. They will be fixed
-    # and re-enabled.
-    'base_unittests': [
-        '*',
-    ],
-    # These unittest cases are failing after llvm rebase. They will be fixed
-    # and re-enabled.
-    'net_unittests': [
-        '*',
-    ],
-  }
+  __FILTERED_TESTS = {}  # pylint: disable=invalid-name
diff --git a/testing/gtest/include/gtest/internal/gtest-port.h b/testing/gtest/include/gtest/internal/gtest-port.h
@@ -1297,10 +1297,13 @@ class GTEST_API_ GTestLog {
 };
 
 #if !defined(GTEST_LOG_)
-
+#if GTEST_OS_STARBOARD
+#define GTEST_LOG_ SB_LOG
+#else
 # define GTEST_LOG_(severity) \
     ::testing::internal::GTestLog(::testing::internal::GTEST_##severity, \
                                   __FILE__, __LINE__).GetStream()
+#endif
 
 inline void LogToStderr() {}
 #if GTEST_OS_STARBOARD