Bit twiddle tweaks #934
Merged
Bit twiddle tweaks #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As requested here: ykjit#930 (comment)
These are constants for use when we are shifting a field in to (or out of) position from (or to) the LSB.
This is a constant that applies only to short instructions, so name it so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hopefully addresses something we discussed at the end of last year: that all bit-twiddling computations for the JIT IR should (where possible) be defined as constants at the top of the file with as little duplication in the main body of code as possible.
While here, I've also tweaked some related bits.
All commits stand alone.
No functional change. Let me know what you think.