Skip to content

Commit

Permalink
Fix std::shared_mutex missing includes (facebookincubator#10772)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: facebookincubator#10772

This showed up in some OSS builds; includes are missing in headers
that need the class.

Reviewed By: xiaoxmeng

Differential Revision: D61405677

fbshipit-source-id: 23ed1af997303c421c413ea63b9ee21ee27a75b2
  • Loading branch information
pedroerp authored and facebook-github-bot committed Aug 16, 2024
1 parent 6b98060 commit 2b7f559
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 3 deletions.
5 changes: 3 additions & 2 deletions velox/common/caching/SsdFile.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,13 @@

#pragma once

#include <gflags/gflags.h>
#include <shared_mutex>

#include "velox/common/caching/AsyncDataCache.h"
#include "velox/common/caching/SsdFileTracker.h"
#include "velox/common/file/File.h"

#include <gflags/gflags.h>

DECLARE_bool(ssd_odirect);
DECLARE_bool(ssd_verify_write);

Expand Down
1 change: 1 addition & 0 deletions velox/common/config/Config.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

#include <functional>
#include <map>
#include <shared_mutex>
#include <unordered_map>

#include "folly/Conv.h"
Expand Down
3 changes: 2 additions & 1 deletion velox/common/memory/SharedArbitrator.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,14 @@

#pragma once

#include "velox/common/memory/MemoryArbitrator.h"
#include <shared_mutex>

#include "velox/common/base/Counters.h"
#include "velox/common/base/GTestMacros.h"
#include "velox/common/base/StatsReporter.h"
#include "velox/common/future/VeloxPromise.h"
#include "velox/common/memory/Memory.h"
#include "velox/common/memory/MemoryArbitrator.h"

namespace facebook::velox::memory {

Expand Down
1 change: 1 addition & 0 deletions velox/exec/tests/TableScanTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
#include <folly/synchronization/Baton.h>
#include <folly/synchronization/Latch.h>
#include <atomic>
#include <shared_mutex>
#include "folly/experimental/EventCount.h"
#include "velox/common/base/Fs.h"
#include "velox/common/base/tests/GTestUtils.h"
Expand Down

0 comments on commit 2b7f559

Please sign in to comment.