Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge OpenMP branch to master #8

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Merge OpenMP branch to master #8

wants to merge 8 commits into from

Conversation

macrocosme
Copy link
Collaborator

This pull request includes addition of the option to utilise OpenMP (or not) to parallelize a number of compute intensive code sections.

@macrocosme macrocosme requested a review from ymaan4 February 19, 2021 09:39
Copy link
Owner

@ymaan4 ymaan4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a test run using a common input data file and same command line parameters, the output data files from the current master and the dev_omp_merged branch seem to not match with each other. The comparison was done using the 'diff' command. The variable indicating the number of threads was not used, so the default number of threads were used in this test run.

@macrocosme
Copy link
Collaborator Author

I'll have a look soon then. It must be that something got mixed up during merge.

@macrocosme
Copy link
Collaborator Author

The issue has been fixed. The problem was related to the introduction of the variable thread_num in cleanit() that was not included as private for the omp parallel for blocks. I tested running after compiling with openmp for 16 threads and 1 thread, as well as without openmp, and the outputs were the same in all cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants