Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(🎁) run the ci on pull requests #491

Merged
merged 1 commit into from
Oct 15, 2023
Merged

Conversation

KotlinIsland
Copy link
Contributor

@KotlinIsland KotlinIsland commented Oct 12, 2023

Description

Run ci on pull requests

Expected Behavior

Formatting / lint / tests will make the PR fail

@ymyzk
Copy link
Owner

ymyzk commented Oct 14, 2023

@KotlinIsland Could you use the new PR template so that people can understand the necessary summary, motivation, context, and expected behavior of the change?

@KotlinIsland
Copy link
Contributor Author

@KotlinIsland Could you use the new PR template so that people can understand the necessary summary, motivation, context, and expected behavior of the change?

Okay, I've updated the description as specified.

@ymyzk
Copy link
Owner

ymyzk commented Oct 15, 2023

Thanks for updating the ticket description.

@@ -53,6 +53,7 @@ jobs:
- test_app
- test_frontend
runs-on: ubuntu-latest
if: github.ref == 'refs/heads/main'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this project still uses master as the default branch name, this if doesn't have any effects. I'll fix this by myself.

@ymyzk ymyzk merged commit a6e37e1 into ymyzk:master Oct 15, 2023
3 checks passed
@ymyzk ymyzk mentioned this pull request Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants