Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update workflow to support basedmypy #781

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KotlinIsland
Copy link
Contributor

Description

update shell scripts to support inputs like basedmypy-2.8.0

Expected Behavior

shell scripts can now generate configurations for basedmypy

case $version in
"basedmypy-"*)
echo "basedmypy==${version#basedmypy-}" > "requirements.in"
*)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the following error when running the updated script. There might be a syntax error?

./sandbox/add_version.sh: line 32: syntax error near unexpected token `)'

Here's the shellcheck result for reference:

[Line 29:](javascript:setPosition(29, 1))
case $version in
^-- [SC1009](https://www.shellcheck.net/wiki/SC1009) (info): The mentioned syntax error was in this case expression.
 
[Line 30:](javascript:setPosition(30, 3))
  "basedmypy-"*)
  ^-- [SC1073](https://www.shellcheck.net/wiki/SC1073) (error): Couldn't parse this case item. Fix to allow more checks.
 
[Line 32:](javascript:setPosition(32, 4))
  *)
   ^-- [SC1072](https://www.shellcheck.net/wiki/SC1072) (error): Fix any mentioned problems and try again.
   ^-- [SC1074](https://www.shellcheck.net/wiki/SC1074) (error): Did you forget the ;; after the previous case item?

@KotlinIsland KotlinIsland marked this pull request as draft December 13, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants