Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project name as container data for loading and updating assets #23

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

moonyuet
Copy link
Member

Changelog Description

This PR is to add the context["project"]["name"] as part of the container data for loading and updating assets

Additional review information

Please test along with this PR ynput/ayon-core#1005

Testing notes:

  1. Launch Max
  2. Load assets across different library projects

@moonyuet moonyuet self-assigned this Nov 21, 2024
@moonyuet moonyuet changed the title Add project name as container data for loading and updating Add project name as container data for loading and updating assets Nov 21, 2024
@iLLiCiTiT iLLiCiTiT added the type: enhancement Improvement of existing functionality or minor addition label Nov 22, 2024
@iLLiCiTiT
Copy link
Member

Didn' test it @antirotor could you?

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im able to load from Library project but Im not getting project name anywhere but ordinary model and variant....is that right?? I guess not.

here is example with library loaded crateBox model into my active workfile...

image

Copy link
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked for me, but as @LiborBatek mentioned, no project info in scene inventory - or to be more precise - there is info, but shouldn't it be library project?. I also got this <Entity N/A> label:

image

Note, that this is just simple buddha OBJ file published via tray publisher to library project.

@moonyuet
Copy link
Member Author

It worked for me, but as @LiborBatek mentioned, no project info in scene inventory. I also got this <Entity N/A> label:

image

Note, that this is just simple buddha OBJ file published via tray publisher to library project.

have you tested with the ayon-core PR?

@antirotor
Copy link
Member

antirotor commented Nov 22, 2024

Oh f*ck, sorry. I had to change the ayon-core branch because of the dependency package rebuild and forgot the switch it back again...

I take it back, I didn't forget - I am on the correct branch.

@moonyuet
Copy link
Member Author

moonyuet commented Nov 22, 2024

Oh f*ck, sorry. I had to change the ayon-core branch because of the dependency package rebuild and forgot the switch it back again...

I take it back, I didn't forget - I am on the correct branch.

but it works in my side.
image

Video_for_loading_asset_across_library_project.mp4

Copy link
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works now, not sure why - but thats good news, no? :)

@LiborBatek LiborBatek self-requested a review November 25, 2024 14:38
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After clarification of whats expected I have re-run the tests and it works correctly for me too...

image

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants