Reset Unit Scale default to False in ayon setting and Popup menu before the reset

[moonyuet]

Changelog Description

Resolve #30
This PR is to set the reset unit scale default value to False and also add popup window to alter user for the change of the unit scale.

Additional review information

n/a

Testing notes:

1. Install and Build 3dsmax addon
2. Check ayon+settings://max/unit_scale_settings
3. It should be False
4. Enable it
5. Launch Max
6. There would be popup menu to ask you if you want to reset unit scale.

[LiborBatek]

Following the testing steps, it is correctly disabled as defaults within addons setting:

but once enabled Im getting this error just right away after 3dsmax launch:

[LiborBatek]

Once setting Set Unit Scale enabled then popup win been shown

but first issue is that it shows up on pretty every occasion no matter if units been correct or not:

e.g. when creating new scene via CTRL+N and also been set to correct units.

Besides its unnecessary its very annoying to face it each time...some logic need to be on place and show up only when mismatch of scene units happening...

[LiborBatek]

speaking of new scene...it should probably just force setting the prefered units without any popup win showing....imho, simply following studio preferences (when Set unit Scale been enabled in AYON)

Speaking of that pop up message. maybe there should be info note similar to this:

Scene units do not match studio/project preferences. Would you like to set your scene unit scale to 'cm` ?

[moonyuet]

speaking of new scene...it should probably just force setting the prefered units without any popup win showing....imho, simply following studio preferences (when Set unit Scale been enabled in AYON)

Speaking of that pop up message. maybe there should be info note similar to this:

Scene units do not match studio/project preferences. Would you like to set your scene unit scale to 'cm` ?

The updated commit should only show the popup when you hit the set unit scale from the AYON plugins

[LiborBatek]

Tested again...and my findings so far:

1. when Set unit Scale enabled in the addons setting then it forces the unit scale automatically when launched via launcher for very first time (without notification at all) > would be better to first inform the user via that info message first and let him choose what happens next

2. when changing context via Ayon > Workfiles then it does not apply any Set unit scale at all neither telling user that units are mismatching if true (in my case yes) > again I would rather expect to showing popup of unit scale mismatch and offer set scale action to user then doing nothing...a bit useless atm

3. when using AYON menu and trigger the action Set unit scale I can finally see the popup which is not looking the best (speaking of formatting)
   

and also doesnt make much sense at this moment to show such info as user triggered by himself so its a bit useless to say something about different units been used then studio prefs.

In general it should copy the way when in maya host and mismatch of FPS > first inform user if any mismatch present and offer set scale command to fix it if preferable by user.

As we have it right now (Set unit scale action) , it basically dont let user to choose or inform him when its needed... and just perfom it after launch from the launcher app or do nothing when its actually needed (when changing context and approach scene with mismatched units)

[moonyuet]

Tested again...and my findings so far:

1. when Set unit Scale enabled in the addons setting then it forces the unit scale automatically when launched via launcher for very first time (without notification at all) > would be better to first inform the user via that info message first and let him choose what happens next
2. when changing context via Ayon > Workfiles then it does not apply any Set unit scale at all neither telling user that units are mismatching if true (in my case yes) > again I would rather expect to showing popup of unit scale mismatch and offer set scale action to user then doing nothing...a bit useless atm
3. when using AYON menu and trigger the action Set unit scale I can finally see the popup which is not looking the best (speaking of formatting)
   

and also doesnt make much sense at this moment to show such info as user triggered by himself so its a bit useless to say something about different units been used then studio prefs.

In general it should copy the way when in maya host and mismatch of FPS > first inform user if any mismatch present and offer set scale command to fix it if preferable by user.

As we have it right now (Set unit scale action) , it basically dont let user to choose or inform him when its needed... and just perfom it after launch from the launcher app or do nothing when its actually needed (when changing context and approach scene with mismatched units)

I have updated the commit to fix it and you would notice this dialog when you enable scene unit scale.

[LiborBatek]

I do get nice little warning message as when FPS is not matching which I like!

But it seems that the logic when to show it fails, as it does not matter if correct or wrong units been set within a workfile it always pops up this message.

Need to be addressed so it triggers only when valid occasion...

[LiborBatek]

After another testing round I have came across these:

1. Works well when launching from launcher (task) and detects properly if aligned or not with settings
2. Works when changing context via Ayon>Workfiles ok and detects properly again
3. When been in the same context and switching workfile version with units mismatch is not working aka not detected properly. Its a bit of edge case tho....as having different unit scale between version does not happen usually.

e.g. something like this:

shot_020_lighting_workfile_v025 having setcm
shot_020_lighting_workfile_v026 having set mm

Should be addressed too if possible.

[BigRoy]

Didn't test but changes look good to me.

[LiborBatek]

Now it works under all circumstances e.g when launched from the launcher, when switching to different context and going from workfile to workfile within the same context. So all good!

One last note:
there are only metric units and not the US standards like feet and inches. So we should include those too I guess? Even tho there is a plethora of combinations/ configs to be honest....

ideas?