Remove avalon instance id #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moonyuet
added
the
type: enhancement
BigRoy
requested changes
Jan 27, 2025
There was a problem hiding this comment.
This change is incorrect - the older value check should remain to keep supporting backwards compatible legacy instances. The fact that you are looking for both values is correct because most likely existing instances in 3dsmax are using the older value currently.
So likely best to close this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
This PR is to remove deprecated
AVALON_INSTANCE_IDin regard to ynput/ayon-core#1105Additional review information
Tested with ynput/ayon-core#1105
Testing notes: