Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated ocio_config ImageIOConfigModel settings for each addon #785

Closed
19 tasks done
BigRoy opened this issue Jul 18, 2024 · 3 comments
Closed
19 tasks done
Assignees
Labels
type: enhancement Improvement of existing functionality or minor addition

Comments

@BigRoy
Copy link
Collaborator

BigRoy commented Jul 18, 2024

Is there an existing issue for this?

  • I have searched the existing issues.

Please describe the feature you have in mind and explain what the current shortcomings are?

Currently the settings for ayon-houdini contains a deprecated ImageIOConfigModel.

With the support of profiles to determine OCIO config in ayon-core this logic has been superseded and should be removed from each addon still having the deprecated settings.

How would you imagine the implementation of the feature?

Remove the deprecated settings, and ensure transition for existing users is easy.
Since settings have moved, in a potentially backwards incompatible way, there may need to be a transition guide with the release explaining what to do. We may need to also bump the minor version to indicate the breaking changes.

Are there any labels you wish to add?

  • I have added the relevant labels to the enhancement request.

Describe alternatives you've considered:

No response

Additional context:

Part of the cleanup epic ✨

@BigRoy
Copy link
Collaborator Author

BigRoy commented Jul 18, 2024

Oops - can we link multiple PRs but have this only close if ALL of them are merged? If not, I may need to unlink them and just keep them in the PR description. @dee-ynput do you know?

@dee-ynput
Copy link

AFAIK closing one will always close the issue :'(

Mentioning them in the issue body is better in this case (and probably most cases)

I hope GH will change that someday ✨

@BigRoy
Copy link
Collaborator Author

BigRoy commented Jul 25, 2024

@dee-ynput all the listed integrations are now merged - I'll close this one.

@BigRoy BigRoy closed this as completed Jul 25, 2024
@BigRoy BigRoy self-assigned this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

No branches or pull requests

2 participants