Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated ocio_config ImageIOConfigModel settings #28

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Jul 17, 2024

Changelog Description

Remove deprecated ocio_config ImageIOConfigModel settings

Additional info

With the support of profiles to determine OCIO config in ayon-core this logic has been superseded and should be removed from each addon still having the deprecated settings.

@BigRoy BigRoy requested a review from iLLiCiTiT July 17, 2024 18:50
@BigRoy BigRoy self-assigned this Jul 17, 2024
@BigRoy BigRoy marked this pull request as ready for review July 18, 2024 10:14
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

@BigRoy
Copy link
Contributor Author

BigRoy commented Jul 22, 2024

@jakubjezek001 did you do a test run or just check the code? Do we need a test run?

@BigRoy BigRoy requested a review from moonyuet July 23, 2024 22:12
Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully in Maya 2025
image

@BigRoy BigRoy merged commit 0037976 into ynput:develop Jul 24, 2024
1 check passed
@BigRoy BigRoy deleted the chore/remove_deprecated_imageioconfig branch July 24, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants