Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support uppercase extensions in ExtractReview plugin #1107

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

JoseCovaOS
Copy link
Contributor

@JoseCovaOS JoseCovaOS commented Jan 25, 2025

Changelog Description

ExtractReview plugin supports representations with an uppercase extension.

Additional info

This would make ExtractReview plugin process files that may not be in uppercase as in the case described in the issue. For instance, a representation with its extension like .Mov would be processed as well.

Testing notes:

We are assuming there is a ExtractReview profile configured for this

  1. Launch traypublisher and try to publish a render whose representation has .MOV extension.
  2. Check ftrack, assetversion should have a reviewable component.

@ynbot ynbot added size/XS type: bug Something isn't working labels Jan 25, 2025
@BigRoy BigRoy requested review from antirotor and iLLiCiTiT January 27, 2025 12:01
@dee-ynput dee-ynput linked an issue Jan 27, 2025 that may be closed by this pull request
2 tasks
@BigRoy
Copy link
Collaborator

BigRoy commented Jan 27, 2025

Just want to remark that doing this would still generate a representation in the end that's named e.g. MOV instead of mov which may or may not influence other areas too. Whether that's preferred or not I'll leave for discussion but be aware that that's the case.

@iLLiCiTiT
Copy link
Member

iLLiCiTiT commented Jan 31, 2025

Just want to remark that doing this would still generate a representation in the end that's named e.g. MOV instead of mov which may or may not influence other areas too. Whether that's preferred or not I'll leave for discussion but be aware that that's the case.

I kinda agree with Roy here. Where are the files comming from? If it is traypublisher, maybe we should change how traypublisher creates them, instead of ad-hoc fix in in ExtractReview.

@JoseCovaOS
Copy link
Contributor Author

@iLLiCiTiT files came from the traypublisher

@iLLiCiTiT
Copy link
Member

iLLiCiTiT commented Jan 31, 2025

In that case I would move the fix to traypublisher, as this would fix only reviewables (partial fix at wrong place), we probably should fix all other cases too...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ExtractReview does not process representations with uppercase extension
4 participants